Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: improve sub-process debug logging #129

Merged
merged 1 commit into from
Jul 22, 2022

Conversation

Jdunsby
Copy link
Contributor

@Jdunsby Jdunsby commented Jul 21, 2022

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

Adds additional debug logs to the sub-process's "exit" event handler when the exit code isn't 0. The debug logs include all stdout and stderr up until that point, as well as the exit code.
Also added the DEBUG=* env variable to the suggested debug command.

@Jdunsby Jdunsby requested a review from a team as a code owner July 21, 2022 11:43
lib/sub-process.ts Outdated Show resolved Hide resolved
@Jdunsby Jdunsby force-pushed the feat/improve-sub-process-debug-logging branch from 1651fdd to 2d0dcf6 Compare July 21, 2022 13:02
@Jdunsby Jdunsby force-pushed the feat/improve-sub-process-debug-logging branch 3 times, most recently from fc99eed to a455c4e Compare July 22, 2022 11:38
@Jdunsby Jdunsby force-pushed the feat/improve-sub-process-debug-logging branch from a455c4e to 038f7df Compare July 22, 2022 11:48
@Jdunsby Jdunsby force-pushed the feat/improve-sub-process-debug-logging branch from 038f7df to 21b6857 Compare July 22, 2022 11:52
@Jdunsby Jdunsby merged commit 7afa8d5 into master Jul 22, 2022
@Jdunsby Jdunsby deleted the feat/improve-sub-process-debug-logging branch July 22, 2022 12:08
@snyksec
Copy link

snyksec commented Jul 22, 2022

🎉 This PR is included in version 2.30.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants