fix: unmanaged scan unknown archives #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of skipping over unknown archives, add them to the dep-graph as unknown so that users can see those archives. Helps users understand what has and what has not been scanned.
magdziarek
reviewed
Sep 15, 2022
| resolve({ | ||
| g: 'unknown', | ||
| a: `${targetPath}:${sha1}`, | ||
| v: 'unknown', |
There was a problem hiding this comment.
here we might have a version or group at this point but we decide to mark both as unknown to flag that this is where we cut the transitive path because we couldn't resolve it, right?
There was a problem hiding this comment.
we don't have either, marking version as 'unknown' makes the UI alert the user, marking group as unknown allows the user to search for them
magdziarek
approved these changes
Sep 15, 2022
|
🎉 This PR is included in version 2.31.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
1 task
gitphill
added a commit
to snyk/cli
that referenced
this pull request
Sep 29, 2022
See snyk/snyk-mvn-plugin#137 Adding warning message to indicate when projects have a dep-graph that contains packages with unknown versions (like in the Snyk UI).
ChristinaDara
pushed a commit
to snyk/cli
that referenced
this pull request
Jan 23, 2023
See snyk/snyk-mvn-plugin#137 Adding warning message to indicate when projects have a dep-graph that contains packages with unknown versions (like in the Snyk UI).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of skipping over unknown archives, add them to the dep-graph as unknown so that users can see those archives.
Helps users understand what has and what has not been scanned.