New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: issues with windows #12

Merged

aryehbeitz merged 1 commit into master from fix/windows_tests

Dec 7, 2017

Contributor

aryehbeitz commented Dec 7, 2017

mkdir is not necessary. lodash-cli on all versions(linux and windows) creates dist
the directory must be specified for lodash (at least in windows), since we do not expect it to be installed globally
find in tap tests replaced with alternate which works both in windows and linux


          fix: issues with windows

b51ac1e

aryehbeitz requested a review from adrukh

December 7, 2017 13:40

Contributor Author

aryehbeitz commented Dec 7, 2017

@adrukh
your thoughts?

adrukh approved these changes

View reviewed changes

aryehbeitz merged commit 5d927d2 into master

aryehbeitz deleted the fix/windows_tests branch

December 7, 2017 19:03

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment