Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BREAKING CHANGE: drop unused groupId and artifactId attributes from response #18

Merged
merged 1 commit into from
Sep 25, 2018
Merged

BREAKING CHANGE: drop unused groupId and artifactId attributes from response #18

merged 1 commit into from
Sep 25, 2018

Conversation

darscan
Copy link
Contributor

@darscan darscan commented Sep 24, 2018 •
edited

  • Ready for review
  • Follows CONTRIBUTING rules
  • Reviewed by Snyk internal team

What does this PR do?

  • removes unused groupId and artifactId from response

Any background context you want to provide?

  • the current dependency tree format is very verbose and this gives us a tiny bit more headroom for large projects

@darscan darscan self-assigned this Sep 24, 2018
@CLAassistant
Copy link

CLAassistant commented Sep 24, 2018 •
edited

CLA assistant check
All committers have signed the CLA.

adrukh
adrukh approved these changes Sep 24, 2018
View reviewed changes
Copy link
Contributor

@adrukh adrukh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah no tests depended on these two keys...

@darscan darscan merged commit 330713d into master Sep 25, 2018
@darscan darscan deleted the feat/drop-group-id-and-artifact-id branch September 25, 2018 10:39
@snyksec
Copy link

snyksec commented Sep 25, 2018

🎉 This PR is included in version 2.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adrukh adrukh adrukh approved these changes

Assignees

@darscan darscan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@darscan @CLAassistant @snyksec @adrukh