Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add dataflow to code issue data [IDE-134] #5076

Merged
merged 1 commit into from Feb 26, 2024

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Feb 26, 2024

Pull Request Submission

Please check the boxes once done.

The pull request must:

  • Reviewer Documentation
    • follow CONTRIBUTING rules
    • be accompanied by a detailed description of the changes
    • contain a risk assessment of the change (Low | Medium | High) with regards to breaking existing functionality. A change e.g. of an underlying language plugin can completely break the functionality for that language, but appearing as only a version change in the dependencies.
    • highlight breaking API if applicable
    • contain a link to the automatic tests that cover the updated functionality.
    • contain testing instructions in case that the reviewer wants to manual verify as well, to add to the manual testing done by the author.
    • link to the link to the PR for the User-facing documentation
  • User facing Documentation
    • update any relevant documentation in gitbook by submitting a gitbook PR, and including the PR link here
    • ensure that the message of the final single commit is descriptive and prefixed with either feat: or fix: , others might be used in rare occasions as well, if there is no need to document the changes in the release notes. The changes or fixes should be described in detail in the commit message for the changelog & release notes.
  • Testing
    • Changes, removals and additions to functionality must be covered by acceptance / integration tests or smoke tests - either already existing ones, or new ones, created by the author of the PR.

What does this PR do?

This updates Language Server to the latest version, which includes snyk/snyk-ls#449. This enables the IDEs to display a correct dataflow, and it is needed to feed the IntelliJ Snyk Code integration of LS. This also integrates the latest Go Application Framework (snyk/go-application-framework@d58d5f3), which only brings CODEOWNER and linter changes.

Risk: LOW

Where should the reviewer start?

snyk/snyk-ls#449

How should this be manually tested?

Build the CLI with this change, then configure the build directory in IntelliJ, using the latest IntelliJ code from snyk/snyk-intellij-plugin#474. Then switch the feature flag in the IntelliJ Registry and test whether the dataflow populates like before.

Any background context you want to provide?

What are the relevant tickets?

IDE-134

Screenshots

Additional questions

@bastiandoetsch bastiandoetsch requested a review from a team as a code owner February 26, 2024 10:51
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) February 26, 2024 11:55
@bastiandoetsch bastiandoetsch merged commit 6545bec into main Feb 26, 2024
14 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/IDE-134_add_dataflow_to_code_issue_data branch February 26, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants