feat: add dataflow to code issue data [IDE-134] #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
force-pushed
the
feat/IDE-134_add-dataflow-to-code-issue-data
branch
from
fc3ee9f
to
44b959f
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
force-pushed
the
feat/IDE-134_add-dataflow-to-code-issue-data
branch
from
44b959f
to
f6c13b0
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
force-pushed
the
feat/IDE-134_add-dataflow-to-code-issue-data
branch
from
f6c13b0
to
b92568b
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
force-pushed
the
feat/IDE-134_add-dataflow-to-code-issue-data
branch
from
b92568b
to
799a7c5
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
force-pushed
the
feat/IDE-134_add-dataflow-to-code-issue-data
branch
from
799a7c5
to
981de36
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
force-pushed
the
feat/IDE-134_add-dataflow-to-code-issue-data
branch
from
981de36
to
4e07811
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
bastiandoetsch
force-pushed
the
feat/IDE-134_add-dataflow-to-code-issue-data
branch
from
4e07811
to
b00b601
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
This enables display of the dataflow in the custom UIs of the IDEs, as this object is transferred via the $/snyk.scan message. The markers, used in VSCode, are not sufficient for this.
bastiandoetsch
force-pushed
the
feat/IDE-134_add-dataflow-to-code-issue-data
branch
from
b00b601
to
46ae038
Compare
bastiandoetsch
temporarily deployed
to
Standard
GitHub Actions
Inactive
4 tasks
bastiandoetsch
deleted the
feat/IDE-134_add-dataflow-to-code-issue-data
branch
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In order to display the dataflow in the IDE custom UI (see screenshot below), we need additional data. This PR provides it via the
$/snyk.scannotification. This is part of fixing issues for IDE-134.Checklist
🚨After having merged, please update the CLI go.mod to pull in latest language server.
Screenshots / GIFs