Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce vervet-underground #76

Merged
merged 1 commit into from
Nov 25, 2021
Merged

feat: introduce vervet-underground #76

merged 1 commit into from
Nov 25, 2021

Conversation

Todai88
Copy link
Contributor

@Todai88 Todai88 commented Nov 24, 2021

Readme should tell us what we want.

Readme should tell us what we want.
@Todai88 Todai88 requested a review from a team as a code owner November 24, 2021 17:17
@CLAassistant
Copy link

CLAassistant commented Nov 24, 2021

CLA assistant check
All committers have signed the CLA.

Copy link
Contributor

@jcsackett jcsackett left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Using config.json for configuration is a little odd in a go app, isn't it? Is that a company standard rather than the more common yaml or toml config paths most go projects seem to pursue?

@Todai88 Todai88 merged commit a649af3 into main Nov 25, 2021
@Todai88 Todai88 deleted the feat/introduce-vu branch November 25, 2021 10:01
@Todai88
Copy link
Contributor Author

Todai88 commented Nov 25, 2021

LGTM!

Using config.json for configuration is a little odd in a go app, isn't it? Is that a company standard rather than the more common yaml or toml config paths most go projects seem to pursue?

I'm not sure if it's a company standard, but the config library that we created in V3 suggests it maybe is.
Arguably JSON is a bit easier to parse than YAML, but I'm sure we could extend the lib to use YAML too, if we wanted to :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants