fix: proper support for optic git file sources #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to support differential linting against Git repository branches, linters need to be able to determine which files should be compared by looking at both the "from" and "to" file sources. This change introduces support for this, while also making the necessary distinction between collections of files that need to be compared for linting, and files that need to be compiled into aggregate OpenAPI specs.
ianlivingstone
approved these changes
Nov 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to support differential linting against Git repository
branches, linters need to be able to determine which files should be
compared by looking at both the "from" and "to" file sources. This
change introduces support for this, while also making the necessary
distinction between collections of files that need to be compared for
linting, and files that need to be compiled into aggregate OpenAPI
specs.
Also in this PR, some internal linter package restructuring to improve clarity.