fix: restrict optic configuration to supported functionality #82
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmars
force-pushed
the
fix/restrict-optic
branch
from
35e2529
to
9e487d4
Compare
Optic rules are not currently applied to the compiled output stage and this is not yet supported, lacking a clear use case or definition. Optic rules are also not allowed for "overrides". Linter overrides were a stop-gap measure that should be better solved with a more well-defined standards & compliance lifecycle. Add some additional config sanity checks.
cmars
force-pushed
the
fix/restrict-optic
branch
from
9e487d4
to
eb334ad
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Optic rules are not currently applied to the compiled output stage and
this is not yet supported, lacking a clear use case or definition.
Optic rules are also not allowed for "overrides". Linter overrides
were a stop-gap measure that should be better solved with a more
well-defined standards & compliance lifecycle.
Add some additional config sanity checks.