Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add always start with language-server positional arg, add logging args if given [HEAD-693] #374

Merged
merged 5 commits into from
Sep 11, 2023

Conversation

bastiandoetsch
Copy link
Contributor

@bastiandoetsch bastiandoetsch commented Sep 8, 2023

Description

  • always adds language-server as first argument to the args of the language server
  • SNYK_LOG_DEVEL overrules all log level settings now
  • -d or --debug in additional parameters now puts language server in debug mode

Checklist

  • Tests added and all succeed
  • Linted
  • CHANGELOG.md updated
  • README.md updated, if user-facing

Screenshots / GIFs

Visuals that may help the reviewer. Please add screenshots for any UI change. GIFs are most welcome!

…gging args if given `-d` or env var

- SNYK_LOG_DEVEL overrules all log level settings now
- `-d` or `--debug` in additional parameters now puts language server in debug mode

Signed-off-by: Bastian Doetsch <bastian.doetsch@snyk.io>
@bastiandoetsch bastiandoetsch requested a review from a team as a code owner September 8, 2023 12:17
Signed-off-by: Bastian Doetsch <bastian.doetsch@snyk.io>
Signed-off-by: Bastian Doetsch <bastian.doetsch@snyk.io>
Signed-off-by: Bastian Doetsch <bastian.doetsch@snyk.io>
@bastiandoetsch bastiandoetsch changed the title feat: add detection for standalone/cli-embedded based on size, add logging args if given -d or env var [HEAD-693] feat: add always start with language-server positional arg, add logging args if given [HEAD-693] Sep 8, 2023
Signed-off-by: Bastian Doetsch <bastian.doetsch@snyk.io>
@bastiandoetsch bastiandoetsch enabled auto-merge (squash) September 8, 2023 12:38
@bastiandoetsch bastiandoetsch merged commit ffd080f into main Sep 11, 2023
6 checks passed
@bastiandoetsch bastiandoetsch deleted the feat/HEAD-693_add_language-server-argument branch September 11, 2023 10:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants