Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Warning: This appears to be the first time you've run diff-so-fancy" displayed every incocation #244

Closed
SimenB opened this issue Jul 15, 2017 · 5 comments

Comments

@SimenB
Copy link
Contributor

SimenB commented Jul 15, 2017

Using the freshly minted 1.1.0 on mac.

image

Git config: https://github.com/SimenB/vcsh_git/blob/2f94f33d90261c4690c557bbecc9901d1b00edb3/.gitconfig

@SimenB
Copy link
Contributor Author

SimenB commented Jul 15, 2017

This goes away if adding any [color "diff-highlight"]. Which is pretty weird! (and I don't want to, ref screenshots in #243)

@scottchiefbaker
Copy link
Contributor

Ah... you hit a weird corner case. You already have a d-s-f alias, and you don't have an DiffHighlight colors set. You can also just run d-s-f standalone once (not via your git alias) and it will give you this error with a prompt to set default colors, and you can select N.

The issue is that I can't prompt the user to set colors (or set first-run to false) in less, so the only thing I can do is show the warning. I'm not sure what the best "fix" here is. I could modify the usage to explain how to get rid of that error I suppose?

@SimenB
Copy link
Contributor Author

SimenB commented Jul 16, 2017

That worked, thanks!

SimenB/vcsh_git@be83f50

And yes, a better message would be nice 🙂

@scottchiefbaker
Copy link
Contributor

@SimenB I'd love a Pull Request on this if you want to try and change the usage for this.

@SimenB
Copy link
Contributor Author

SimenB commented Jul 17, 2017

@SimenB I'd love a Pull Request on this if you want to try and change the usage for this.

Sure, #250 is a first try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants