Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encoding issue or broken sed command #7

Closed
aziz opened this issue Feb 8, 2016 · 5 comments
Closed

Encoding issue or broken sed command #7

aziz opened this issue Feb 8, 2016 · 5 comments
Labels

Comments

@aziz
Copy link
Contributor

aziz commented Feb 8, 2016

screen shot 2016-02-08 at 1 45 13 pm

I tried many other fonts in my iTerm terminal.

Interestingly, in Mac Terminal I get an error like this:

sed: -e expression #1, char 211: unterminated `s' command
sed: -e expression #1, char 197: unterminated `s' command
@stevemao stevemao added the bug label Feb 8, 2016
@noscript
Copy link
Member

noscript commented Feb 9, 2016

Sed errors aren't related to the encoding. To fix encoding issue I suggest to switch from tr to sed in print_horizontal_rule():

 print_horizontal_rule () {
-        printf "%$(tput cols)s\n"|tr " " "─"
+        printf "%$(tput cols)s\n"|sed 's/ /─/g'
 }

@aziz
Copy link
Contributor Author

aziz commented Feb 9, 2016

I confirm that this change proposed by @noscript has actually fixed my issue. making it into a pull request.

@aziz aziz closed this as completed in d263251 Feb 9, 2016
aziz added a commit that referenced this issue Feb 9, 2016
Using sed instead of tr  fixed #7
@stevemao
Copy link
Member

stevemao commented Feb 9, 2016

@noscript What's your npm name? I'll add you :)

@noscript
Copy link
Member

noscript commented Feb 9, 2016

~noscript :) just registered

@stevemao
Copy link
Member

stevemao commented Feb 9, 2016

Thanks all for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants