Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New screenshot for readme #98

Closed
paulirish opened this issue Feb 29, 2016 · 12 comments
Closed

New screenshot for readme #98

paulirish opened this issue Feb 29, 2016 · 12 comments

Comments

@paulirish
Copy link
Member

There's been a few changes that aren't reflected in the screenshot or summarized in the readme's text.

e.g. the header_clean, code is flush left, dim foreground on context line

Anybody wanna take a swipe at updating those?

@scottchiefbaker
Copy link
Contributor

Before:
two

After:
one

@paulirish
Copy link
Member Author

here's the side by side composite:

image

look good to folks?

@scottchiefbaker
Copy link
Contributor

Actually this has my in-progress hunk code in it. We might want to hold off until #100 lands?

@paulirish
Copy link
Member Author

ooooh true.

yeah lets wait for 100

edit: and 107

@scottchiefbaker
Copy link
Contributor

Do we have another other pending visual changes? Should I generate new screen shots?

@paulirish
Copy link
Member Author

that's it! we're ready

@scottchiefbaker
Copy link
Contributor

How about this:

both

I tried to get some code that would show off each piece of what dsf does.

@paulirish
Copy link
Member Author

nice! i think this hits most of the main points yeah.

I'd slightly prefer to show another file header in there, and less of the
big green block.. but i also hate to be nitpicking on what diff to use.. :)

On Tue, Mar 8, 2016 at 1:49 PM, Scott Baker notifications@github.com
wrote:

How about this:

[image: both]
https://cloud.githubusercontent.com/assets/3429760/13617626/84f6b924-e534-11e5-82c6-8eae47b5722c.png

I tried to get some code that would show off each piece of what dsf does.


Reply to this email directly or view it on GitHub
#98 (comment)
.

@scottchiefbaker
Copy link
Contributor

I wonder if we shouldn't manufacture some commits just for the purposes of documentation. I looked through like 8 different repos trying to find something perfect and couldn't find anything.

@scottchiefbaker
Copy link
Contributor

How about this:

both

I created a bogus branch "screenshot" and pushed it to the repo. We should be able to do git show 2c24b1d and always have the same code to generate a screen shot from. What do you think? Do we need any other "examples" in our screenshot?

@paulirish
Copy link
Member Author

love it. i tweaked screenshot branch a tad more.

and here's what i got for results:

image

@scottchiefbaker
Copy link
Contributor

Perfect, love it. Ship it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants