Making diff-so-fancy work on OS X out of the box #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pauley-unsaturated
commented
Feb 14, 2016
pauley-unsaturated
commented
- Using bash string quoting '$' to match colors with bsd sed
- Accepting either CSI0m or CSIm as reset sequences
- Emitting only CSIm
- Using bash string quoting '$' to match colors with bsd sed - Accepting either CSI0m or CSIm as reset sequences - Emitting only CSIm
|
Ok, this PR should have been clean... I have no idea why the windows unit test would fail :( |
|
I'll configure the CI now. |
|
Now that we merged the style PR, we have conflicts. @stevemao can you resolve these manually for pauley? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.