Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs example for Popup #86

Closed
nickforddev opened this issue Feb 12, 2019 · 2 comments
Closed

Docs example for Popup #86

nickforddev opened this issue Feb 12, 2019 · 2 comments

Comments

@nickforddev
Copy link

nickforddev commented Feb 12, 2019

There is a minor bug in the example code for Popups:

https://soal.github.io/vue-mapbox/guide/markers&popups.html#popup

<MglPopup :coordinates="coordinates" :anchor="top">
  <VCard> <div>Hello, I'm popup!</div> </VCard>
</MglPopup>

either should be anchor="top" or :anchor="'top'", otherwise top must be a member of the component.

@nickforddev
Copy link
Author

Also, as pointed out in #55, coordinates should not be passed by default, that was confusing

@soal soal added this to To do in Version 1.0 via automation Feb 16, 2019
@soal soal moved this from To do to In progress in Version 1.0 Feb 16, 2019
@soal soal moved this from In progress to Done in Version 1.0 Feb 16, 2019
@soal
Copy link
Owner

soal commented Feb 16, 2019

Fixed in version 0.2

@soal soal closed this as completed Feb 16, 2019
@soal soal moved this from Done to Released in Version 1.0 Feb 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Version 1.0
  
Released
Development

No branches or pull requests

2 participants