maxWidth option

[gnuhel]

Hi,

could you add an option to set the maxWidth of the BottomSheet.
Right now, on landscape mode it fill up the whole screen. I would like it to be more narrow (just like the menu options)

thanks

[gnuhel]

@soarcn I think changing MATCH_PARENT to WRAP_CONTENT is enough

[soarcn]

@gnuhel there is no difference even I set match parent to wrap_content, it is a gridview.
I am developing a feature to support initial capacity of bottomsheet, and could resolve the problem you mentioned.

[soarcn]

sorry I got you wrong...
BottomSheet is targeting to align google's offical guideline which will fill up the whole screen

But I could open an attribute to allow you guys to customize the container

[gnuhel]

@soarcn That would be great.

I meant these lines
https://github.com/soarcn/BottomSheet/blob/master/library/src/main/java/com/cocosw/bottomsheet/BottomSheet.java#L370
https://github.com/soarcn/BottomSheet/blob/master/library/src/main/java/com/cocosw/bottomsheet/BottomSheet.java#L382

Changing it from MATCH_PARENT to WRAP_CONTENT make it not filling up the whole screen, especially on tablet and landscape view

[soarcn]

Yes, but as it is a adapterview, I doubt it would work as you expect. anyway, I will help to figure it out.

[gnuhel]

i tried it and it works.
Probably I also change bottom_sheet_dialog.xml width to wrap_content
https://github.com/soarcn/BottomSheet/blob/master/library/src/main/res/layout/bottom_sheet_dialog.xml#L5

[soarcn]

@gnuhel You can now set wrap_content in your bottomsheet style.

[noinnion]

thank you