Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incomplete object descriptions on top-state #1

Closed
shiwalimohan opened this issue Jul 4, 2013 · 0 comments
Closed

Incomplete object descriptions on top-state #1

shiwalimohan opened this issue Jul 4, 2013 · 0 comments
Assignees
Labels

Comments

@shiwalimohan
Copy link
Contributor

^state-prop attribute of objects on input-link is not copied over to objects on the top-state. Following is the trace from the state.

p o122 --depth 3
(O122 ^bbox B6 ^category location ^focus op_open-locationargument1 ^id 5
^linguistic-desc D8 ^pose P131 ^property P184 ^smem-rep R93)
(B6 ^max M12 ^min M11)
(M12 ^x 0.1 ^y 0.1 ^z 0.1)
(M11 ^x -0.1 ^y -0.1 ^z -0.1)
(D8 ^word pantry)
(P131 ^pitch 0. ^roll 0. ^x -0.2 ^y 0.2 ^yaw 0. ^z 0.)
(P184 ^name name ^type linguistic ^value V36 ^word pantry)
(V36 ^word pantry)
(R93 ^id 5 ^wme-type object)

p o19 --depth 3
(O19 ^bbox B6 ^id 5 ^name pantry ^pose P131 ^state-prop S31)
(B6 ^max M12 ^min M11)
(M12 ^x 0.1 ^y 0.1 ^z 0.1)
(M11 ^x -0.1 ^y -0.1 ^z -0.1)
(P131 ^pitch 0. ^roll 0. ^x -0.2 ^y 0.2 ^yaw 0. ^z 0.)
(S31 ^name door ^type state ^value open)

@ghost ghost assigned amininger Jul 4, 2013
PLindes added a commit that referenced this issue Dec 29, 2018
There is a commit of this same name in the Lucia project.
This set of changes basically makes a number of vocabulary items work in Rosie that did not before by changing Lucia's grammar and smem to have the same handles/names for those items as Rosie, and than copying those grammar changes into the Rosie project.
After the last commit there were 114 FAILUREs in lucia-log.txt.  Now there are only 58.  Those that remain include 27 ^action, 15 ^2 and 12 ^arg1 errors, plus a few other miscellaneous.  There are now still 19 "syntactic" errors, which overlap with the others.
Still more to come.
PLindes added a commit that referenced this issue May 25, 2021
5/25/2021: A new TheKitchen construction was added to help getting "the kitchen" to ground either to the world or to smem. This adds five rules and works very nicely without any other changes. Part of the trace of running this in Rosie shows the preference based on lexicals, demonstrating semantic precision, and looks like this:

Received word #1: go
Matched a SimpleAction construction. C952
Received word #2: to
Received word #3: the
Received word #4: kitchen
Prefer >span: TheKitchen(2) > BareNoun(1).
Prefer >span: SpecNoun(2) > BareNoun(1).
Prefer >lexicals: TheKitchen(2) > SpecNoun(0).
Matched a TheKitchen construction. C971
Matched a SimplePrepPhrase construction. C975
Snipping C952 to get to C951 .
Attach PrepPhrase C975 to DriveVerb C951 .
Matched a DriveVerbToTarget construction. C977
Sentence #2: "go to the kitchen"

This makes "the kitchen" work very similarly to "the main office", whose trace looks like this:

Received word #1: go
Matched a SimpleAction construction. C1101
Received word #2: to
Received word #3: the
Received word #4: main
Received word #5: office
Prefer >span: TheMainOffice(3) > BareNoun(1).
Prefer >span: PropertyNoun(2) > BareNoun(1).
Prefer >span: SpecPropNoun(3) > BareNoun(1).
Prefer >lexicals: TheMainOffice(3) > SpecPropNoun(0).
Prefer >span: SpecPropNoun(3) > PropertyNoun(2).
Prefer >span: TheMainOffice(3) > PropertyNoun(2).
Matched a TheMainOffice construction. C1125
Matched a SimplePrepPhrase construction. C1129
Snipping C1101 to get to C1100 .
Attach PrepPhrase C1129 to DriveVerb C1100 .
Matched a DriveVerbToTarget construction. C1131
Sentence #2: "go to the main office"
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants