Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build problem #25

Closed
zvonimir opened this issue Jan 29, 2019 · 6 comments
Closed

Build problem #25

zvonimir opened this issue Jan 29, 2019 · 6 comments
Assignees

Comments

@zvonimir
Copy link
Member

A collaborator tried to build Gelpia and he run into the following build error:

   Compiling getopts v0.2.18
error[E0301]: cannot mutably borrow in a pattern guard
    --> 
/home/volodya/.cargo/registry/src/github.com-1ecc6299db9ec823/getopts-0.2.18/src/lib.rs:407:73
     |
407 |                         } else if was_long || name_pos < names.len() 
|| args.peek().map_or(true, |n| is_arg(&n)) {
     | 
^^^^ borrowed mutably in pattern guard

error: aborting due to previous error

Build failed, waiting for other jobs to finish...
error: Could not compile `getopts`.

Could someone help us out to get to the bottom of this?

@zvonimir
Copy link
Member Author

I guess it might be related to the used version of Rust or something like that.

@ganeshutah
Copy link

ganeshutah commented Jan 29, 2019 via email

@IanBriggs
Copy link
Collaborator

IanBriggs commented Jan 29, 2019 via email

@zvonimir
Copy link
Member Author

Thanks Ian!
Yeah, this is almost certainly being done from the master branch. I would guess the person was just following our instructions.
@keram88 is the Rust version pinned in the master branch?
Any other suggestions? Thanks!

@keram88
Copy link
Member

keram88 commented Jan 30, 2019

This is the same issue as this:
#24 (comment)

If I remember correctly, the issue has something to do with a compatible version of getopts not being available and requiring some changes in the Python front end. I guess it got lost at ATVA. I'll have to stare at the code again to figure it out and work on a solution with Ian.

@keram88
Copy link
Member

keram88 commented Sep 12, 2019

This has been resolved in the develop branch. We have an upcoming version that uses stable Rust and we are working to reduce dependencies now that the language has matured enough.

@keram88 keram88 closed this as completed Sep 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants