⛔ Unused variable warnings

- C++17 constexpr and comparison operators also sucks, so there's that...!
soasis · Feb 22, 2021 · 59f2dff · 59f2dff
1 parent e1c1bcb
commit 59f2dff
Show file tree

Hide file tree

Showing 5 changed files with 39 additions and 2 deletions.
diff --git a/include/ztd/text/unicode_code_point.hpp b/include/ztd/text/unicode_code_point.hpp
@@ -57,7 +57,7 @@ namespace ztd { namespace text {
 			/// or with the value 0 (if parentheses/brackets are provided for intentional value initialization).
 			///
 			//////
-			constexpr __unicode_code_point() noexcept = default;
+			__unicode_code_point() noexcept = default;
 
 			//////
 			/// @brief Constructs a code point value with the given code point value.
@@ -119,6 +119,17 @@ namespace ztd { namespace text {
 				return __left._M_scalar == __right._M_scalar;
 			}
 
+			//////
+			/// @brief Check if two unicode code points are not equal.
+			///
+			/// @param[in] __left Left hand value of inequality operator.
+			/// @param[in] __right Right hand value of inequality operator.
+			//////
+			friend constexpr bool operator!=(
+				const __unicode_code_point& __left, const __unicode_code_point& __right) {
+				return __left._M_scalar != __right._M_scalar;
+			}
+
 			//////
 			/// @brief Check if one unicode code point is less than the other.
 			///

diff --git a/include/ztd/text/unicode_scalar_value.hpp b/include/ztd/text/unicode_scalar_value.hpp
@@ -60,7 +60,7 @@ namespace ztd { namespace text {
 			/// with the value 0 (if parentheses/brackets are provided for intentional value initialization).
 			///
 			//////
-			constexpr __unicode_scalar_value() noexcept = default;
+			__unicode_scalar_value() noexcept = default;
 
 			//////
 			/// @brief Constructs a scalar value with the given code point value.
@@ -124,6 +124,17 @@ namespace ztd { namespace text {
 				return __left._M_scalar == __right._M_scalar;
 			}
 
+			//////
+			/// @brief Check if two unicode code points are not equal.
+			///
+			/// @param[in] __left Left hand value of inequality operator.
+			/// @param[in] __right Right hand value of inequality operator.
+			//////
+			friend constexpr bool operator!=(
+				const __unicode_scalar_value& __left, const __unicode_scalar_value& __right) {
+				return __left._M_scalar != __right._M_scalar;
+			}
+
 			//////
 			/// @brief Check if one unicode scalar value is less than the other.
 			///

diff --git a/tests/basic_compile_time/CMakeLists.txt b/tests/basic_compile_time/CMakeLists.txt
@@ -42,6 +42,11 @@ if (MSVC)
 else()
 	target_compile_options(ztd.text.tests.basic_compile_time
 		PRIVATE -std=c++2a -Wall -Werror -Wpedantic -fexec-charset=UTF-8)
+	if (CMAKE_CXX_COMPILER_ID MATCHES "Clang")
+		target_compile_options(ztd.text.tests.basic_compile_time
+			PRIVATE -fconstexpr-steps=2097152)
+		endif()
+	endif()
 endif()
 target_include_directories(ztd.text.tests.basic_compile_time
 	PRIVATE 

diff --git a/tests/basic_run_time/source/text.cpp b/tests/basic_run_time/source/text.cpp
@@ -37,17 +37,22 @@
 TEST_CASE("text/text/basic", "basic usages of text do not explode") {
 	SECTION("execution") {
 		ztd::text::text txt;
+		(void)txt;
 	}
 	SECTION("wide_execution") {
 		ztd::text::wtext txt;
+		(void)txt;
 	}
 	SECTION("utf8") {
 		ztd::text::u8text txt;
+		(void)txt;
 	}
 	SECTION("utf16") {
 		ztd::text::u16text txt;
+		(void)txt;
 	}
 	SECTION("utf32") {
 		ztd::text::u32text txt;
+		(void)txt;
 	}
 }
diff --git a/tests/basic_run_time/source/text_view.cpp b/tests/basic_run_time/source/text_view.cpp
@@ -37,17 +37,22 @@
 TEST_CASE("text/text_view/basic", "basic usages of text_view do not explode") {
 	SECTION("execution") {
 		ztd::text::text_view txt;
+		(void)txt;
 	}
 	SECTION("wide_execution") {
 		ztd::text::wtext_view txt;
+		(void)txt;
 	}
 	SECTION("utf8") {
 		ztd::text::u8text_view txt;
+		(void)txt;
 	}
 	SECTION("utf16") {
 		ztd::text::u16text_view txt;
+		(void)txt;
 	}
 	SECTION("utf32") {
 		ztd::text::u32text_view txt;
+		(void)txt;
 	}
 }