Skip to content

Commit

Permalink
馃敤 The clang bug has been resolved for literal encodings
Browse files Browse the repository at this point in the history
  • Loading branch information
ThePhD committed Jun 30, 2021
1 parent 717f3c7 commit 97ed9af
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 14 deletions.
5 changes: 3 additions & 2 deletions examples/shift_jis/source/main.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ int main() {
std::cerr << "Could not initialize the input stream with the file " << file_name << std::endl;
return 1;
}
if (!input_file) {
if (!expected_input_file) {
std::cerr << "Could not initialize the expected input stream with the file " << expected_file_name
<< std::endl;
return 1;
Expand All @@ -70,7 +70,8 @@ int main() {
ZTD_TEXT_ASSERT(std::equal(utf8_string.cbegin(), utf8_string.cend(), utf8_bytes.cbegin(), utf8_bytes.cend()));
ZTD_TEXT_ASSERT(std::equal(
shift_jis_string.cbegin(), shift_jis_string.cend(), shift_jis_bytes.cbegin(), shift_jis_bytes.cend()));

std::cout << utf8_string << std::endl;

return 0;
}
}
8 changes: 2 additions & 6 deletions include/ztd/text/literal.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -175,9 +175,7 @@ namespace ztd { namespace text {
"-compiler-feature-macro-for-narrow-literal-foo-enc.html) and leave a (strong, but very nicely "
"spoken) request to implement the functionality. If you are part of the C++ Standards Committee, "
"please make sure p1885 (https://wg21.link/p1885) gets passed so we don't need to keep doing this "
"nonsense. If you are from Clang, please see my comment here "
"(https://reviews.llvm.org/D88741#2352203) and kindly encourage them to implement this. If you are "
"on some other compiler,\n\n"
"nonsense. If you are on some other compiler,\n\n"

"God's Speed.\n\n"

Expand Down Expand Up @@ -239,9 +237,7 @@ namespace ztd { namespace text {
"-compiler-feature-macro-for-narrow-literal-foo-enc.html) and leave a (strong, but very nicely "
"spoken) request to implement the functionality. If you are part of the C++ Standards Committee, "
"please make sure p1885 (https://wg21.link/p1885) gets passed so we don't need to keep doing this "
"nonsense. If you are from Clang, please see my comment here "
"(https://reviews.llvm.org/D88741#2352203) and kindly encourage them to implement this. If you are "
"on some other compiler,\n\n"
"nonsense. If you are on some other compiler,\n\n"

"God's Speed.\n\n"

Expand Down
8 changes: 2 additions & 6 deletions include/ztd/text/wide_literal.hpp
Original file line number Diff line number Diff line change
Expand Up @@ -183,9 +183,7 @@ namespace ztd { namespace text {
"nicely "
"spoken) request to implement the functionality. If you are part of the C++ Standards Committee, "
"please make sure p1885 (https://wg21.link/p1885) gets passed so we don't need to keep doing this "
"nonsense. If you are from Clang, please see my comment here "
"(https://reviews.llvm.org/D88741#2352203) and kindly encourage them to implement this. If you are "
"on some other compiler,\n\n"
"nonsense. If you are on some other compiler,\n\n"

"God's Speed.\n\n"

Expand Down Expand Up @@ -249,9 +247,7 @@ namespace ztd { namespace text {
"nicely "
"spoken) request to implement the functionality. If you are part of the C++ Standards Committee, "
"please make sure p1885 (https://wg21.link/p1885) gets passed so we don't need to keep doing this "
"nonsense. If you are from Clang, please see my comment here "
"(https://reviews.llvm.org/D88741#2352203) and kindly encourage them to implement this. If you are "
"on some other compiler,\n\n"
"nonsense. If you are on some other compiler,\n\n"

"God's Speed.\n\n"

Expand Down

0 comments on commit 97ed9af

Please sign in to comment.