Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lua: define operator precedence in Lua. #137

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

lua: define operator precedence in Lua. #137

wants to merge 1 commit into from

Conversation

soasme
Copy link
Owner

@soasme soasme commented Sep 16, 2021 •
edited

No description provided.

@soasme
lua: define operator precedence in Lua.
75f4ff8 
XXX: this implementation works but it slows down the performance
significantly. A better approach may be introduced from Peppa PEG
level to support precedence climbing.
@soasme
Copy link
Owner Author

soasme commented Sep 16, 2021

I'm not going to merge this PR anytime soon since this approach will increase the parse time significantly.
It took nearly 20s even if the cli is compiled with -O2 option.

54/54 Test #53: lua-5.4.3/*.lua ..............................   Passed   19.89 sec

A better approach may be introducing precedence climbing at Peppa PEG specification level.

@soasme soasme mentioned this pull request Sep 21, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@soasme