Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add endpoint integration to get product by category #35

Merged

Conversation

italopessoa
Copy link
Member

- #6
- some tech debits are in place, I can fix them o the next PRs, trying to speed things up a little bit. some refactor will happen soon
Copy link

coderabbitai bot commented May 2, 2024

Walkthrough

The recent updates across various components of the ByteMeBurger project mainly enhance functionalities related to product handling and testing. New methods for setting product images and querying products by category have been introduced, alongside improvements in testing strategies with the use of AutoFixture for object creation. Additionally, a specific method in the order repository has been updated with a detailed justification for exclusion from code coverage due to current testing limitations.

Changes

File Path Changes
.../Entities/Product.cs Added public Product() constructor and public void SetImages(string[] images) method.
.../Repository/OrderRepositoryDapper.cs Updated code coverage exclusion justification for GetAllAsync().
.../Repository/ProductRepositoryDapper.cs Enhanced FindByCategory with logic for querying and setting images.
tests/.../Controllers/ProductControllerTest.cs
tests/.../Services/ProductServiceTest.cs
Imported AutoFixture.Kernel namespace; refactored product creation using ProductGenerator.
tests/.../Repository/ProductRepositoryDapperTest.cs Improved readability in _mockConnection setup; added FindByIdAsync_NotImplemented() test method.

Recent Review Details

Configuration used: CodeRabbit UI
Review profile: CHILL

Commits Files that changed from the base of the PR and between a4b7feb and 0bbb6ce.
Files selected for processing (6)
  • src/FIAP.TechChallenge.ByteMeBurger.Domain/Entities/Product.cs (2 hunks)
  • src/FIAP.TechChallenge.ByteMeBurger.Infrastructure/Repository/OrderRepositoryDapper.cs (1 hunks)
  • src/FIAP.TechChallenge.ByteMeBurger.Infrastructure/Repository/ProductRepositoryDapper.cs (2 hunks)
  • tests/FIAP.TechChallenge.ByteMeBurger.Api.Test/Controllers/ProductControllerTest.cs (3 hunks)
  • tests/FIAP.TechChallenge.ByteMeBurger.Application.Test/Services/ProductServiceTest.cs (5 hunks)
  • tests/FIAP.TechChallenge.ByteMeBurger.Infrastructure.Test/Repository/ProductRepositoryDapperTest.cs (3 hunks)
Additional Context Used
GitHub Check Runs (1)
build success (10)

src/FIAP.TechChallenge.ByteMeBurger.Domain/Entities/Product.cs: [warning] 22-22:
Non-nullable property 'Name' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.


src/FIAP.TechChallenge.ByteMeBurger.Domain/Entities/Product.cs: [warning] 22-22:
Non-nullable property 'Description' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.


src/FIAP.TechChallenge.ByteMeBurger.Domain/Entities/Product.cs: [warning] 22-22:
Non-nullable property 'Images' must contain a non-null value when exiting constructor. Consider declaring the property as nullable.


src/FIAP.TechChallenge.ByteMeBurger.Infrastructure/Repository/OrderRepositoryDapper.cs: [warning] 41-41:
The variable 'e' is declared but never used

Path-based Instructions (6)
src/FIAP.TechChallenge.ByteMeBurger.Domain/Entities/Product.cs (1)

Pattern **/*.cs: Validate all files and structures against Domain Driven Design principles and Ports & Adapters architecture pattern.

src/FIAP.TechChallenge.ByteMeBurger.Infrastructure/Repository/ProductRepositoryDapper.cs (1)

Pattern **/*.cs: Validate all files and structures against Domain Driven Design principles and Ports & Adapters architecture pattern.

src/FIAP.TechChallenge.ByteMeBurger.Infrastructure/Repository/OrderRepositoryDapper.cs (1)

Pattern **/*.cs: Validate all files and structures against Domain Driven Design principles and Ports & Adapters architecture pattern.

tests/FIAP.TechChallenge.ByteMeBurger.Infrastructure.Test/Repository/ProductRepositoryDapperTest.cs (1)

Pattern **/*.cs: Validate all files and structures against Domain Driven Design principles and Ports & Adapters architecture pattern.

tests/FIAP.TechChallenge.ByteMeBurger.Application.Test/Services/ProductServiceTest.cs (1)

Pattern **/*.cs: Validate all files and structures against Domain Driven Design principles and Ports & Adapters architecture pattern.

tests/FIAP.TechChallenge.ByteMeBurger.Api.Test/Controllers/ProductControllerTest.cs (1)

Pattern **/*.cs: Validate all files and structures against Domain Driven Design principles and Ports & Adapters architecture pattern.

Additional comments not posted (7)
src/FIAP.TechChallenge.ByteMeBurger.Domain/Entities/Product.cs (1)

49-54: Ensure that direct state modification by SetImages aligns with the overall design philosophy of your domain models. Consider using immutable objects if state changes need to be tracked or undone.

src/FIAP.TechChallenge.ByteMeBurger.Infrastructure/Repository/ProductRepositoryDapper.cs (1)

53-63: The implementation of FindByCategory looks correct. However, consider adding a detailed comment explaining the reason behind excluding this method from code coverage, ensuring it's revisited when the testing framework limitations are resolved.

src/FIAP.TechChallenge.ByteMeBurger.Infrastructure/Repository/OrderRepositoryDapper.cs (1)

58-58: Ensure that the exclusion from code coverage for GetAsync is well-documented and tracked for future resolution when the testing framework limitations are addressed.

tests/FIAP.TechChallenge.ByteMeBurger.Infrastructure.Test/Repository/ProductRepositoryDapperTest.cs (2)

60-61: The setup for the DeleteAsync success test is correctly implemented.


76-77: The setup for the DeleteAsync failure test is correctly implemented.

tests/FIAP.TechChallenge.ByteMeBurger.Application.Test/Services/ProductServiceTest.cs (1)

Line range hint 177-265: The use of AutoFixture in tests is well-implemented, enhancing the setup process. Consider adding comments explaining why AutoFixture was chosen and how it benefits your testing strategy.

tests/FIAP.TechChallenge.ByteMeBurger.Api.Test/Controllers/ProductControllerTest.cs (1)

Line range hint 36-356: The tests in ProductControllerTest are comprehensive and effectively cover the functionality of the ProductController. The use of AutoFixture is consistent and aids in simplifying the setup of test data. Consider adding more detailed comments on the use of AutoFixture to aid future maintainers.


Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media?

Share
Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai generate interesting stats about this repository and render them as a table.
    • @coderabbitai show all the console.log statements in this repository.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (invoked as PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger a review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai help to get help.

Additionally, you can add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.

CodeRabbit Configration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Copy link

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 2

@italopessoa italopessoa merged commit 4662a71 into main May 2, 2024
1 check passed
@italopessoa italopessoa deleted the 6-add-new-endpoint-to-search-products-by-category branch May 6, 2024 12:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api Phase 1 Containers in Software Architecture
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Add new endpoint to search products by category
1 participant