-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create publish-api.yml #64
Conversation
WalkthroughThe new GitHub Actions workflow, Changes
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (1)
- .github/workflows/publish-api.yml (1 hunks)
Additional comments not posted (4)
.github/workflows/publish-api.yml (4)
8-19
: The trigger setup for manual dispatch, pushes, and pull requests targeting the main branch is correctly configured.
21-25
: The environment variables for the Docker registry and image name are correctly set.
32-37
: The job permissions for reading contents, writing packages, and writing an identity token are appropriately configured.
39-74
: The workflow steps for checking out the repository, installing cosign, setting up Docker Buildx, and extracting Docker metadata are correctly configured and use stable versions of actions.
with: | ||
context: . | ||
file: ./src/FIAP.TechChallenge.ByteMeBurger.Api/Dockerfile | ||
push: ${{ github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conditional logic for pushing the Docker image appears to be incorrect. It should push on events other than pull requests, not only on pull requests.
- push: ${{ github.event_name == 'pull_request' }}
+ push: ${{ github.event_name != 'pull_request' }}
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
push: ${{ github.event_name == 'pull_request' }} | |
push: ${{ github.event_name != 'pull_request' }} |
# transparency data even for private images, pass --force to cosign below. | ||
# https://github.com/sigstore/cosign | ||
- name: Sign the published Docker image | ||
if: ${{ github.event_name == 'pull_request' }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The conditional logic for signing the Docker image appears to be reversed. It should sign the image on events other than pull requests, typically when pushing to main or on release tags.
- if: ${{ github.event_name == 'pull_request' }}
+ if: ${{ github.event_name != 'pull_request' }}
Committable suggestion
‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation.
if: ${{ github.event_name == 'pull_request' }} | |
if: ${{ github.event_name != 'pull_request' }} |
No description provided.