-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: set mysql image version #69
Changes from 1 commit
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,9 @@ | ||
# Use the official MySQL image as a base | ||
FROM mysql:latest | ||
FROM mysql:8.3.0 | ||
|
||
# Add our init.sql script to the Docker image | ||
ADD init.sql /docker-entrypoint-initdb.d/ | ||
|
||
# NOTE: use of "mysql_native_password" is not recommended: https://dev.mysql.com/doc/refman/8.0/en/upgrading-from-previous-series.html#upgrade-caching-sha2-password | ||
# (this is just an example, not intended to be a production configuration) | ||
CMD ["mysqld", "--mysql-native-password=ON"] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Consider the security implications of using It's recommended to use more secure authentication methods than |
Original file line number | Diff line number | Diff line change | ||||
---|---|---|---|---|---|---|
@@ -1,7 +1,6 @@ | ||||||
services: | ||||||
api: | ||||||
depends_on: | ||||||
- seq | ||||||
- database | ||||||
container_name: restaurant_api | ||||||
build: | ||||||
|
@@ -27,16 +26,14 @@ | |||||
- MySqlSettings__UserId=${MYSQL_USERID} | ||||||
- MySqlSettings__Password=${MYSQL_PASSWORD} | ||||||
- ASPNETCORE_ENVIRONMENT=Development | ||||||
- Serilog__Write__To__2__Args__serverUr=http://seq:5341 | ||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Correct the typo in the Serilog server URL. - Serilog__Write__To__2__Args__serverUr=http://seq:5341
+ Serilog__Write__To__2__Args__serverUrl=http://seq:5341 Committable suggestion
Suggested change
|
||||||
database: | ||||||
container_name: restaurant_db | ||||||
build: | ||||||
context: ./database | ||||||
dockerfile: Dockerfile | ||||||
tags: | ||||||
- techchallenge/db | ||||||
# NOTE: use of "mysql_native_password" is not recommended: https://dev.mysql.com/doc/refman/8.0/en/upgrading-from-previous-series.html#upgrade-caching-sha2-password | ||||||
# (this is just an example, not intended to be a production configuration) | ||||||
command: --default-authentication-plugin=mysql_native_password | ||||||
- techchallenge/restaurant_db | ||||||
restart: always | ||||||
environment: | ||||||
- MYSQL_ROOT_PASSWORD=admin | ||||||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add a comma for clarity in the testing section.
Committable suggestion