Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent import fixer from preprending ../ with ./ #92

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

rehmsen
Copy link

@rehmsen rehmsen commented Sep 7, 2018

That bug was fixed in the display of the fix, but because import fixing
was using a copy-and-pasted version of the path normalization code,
it never got the fix.

I tested this locally and now it actually works.

Fixes #37 (see PR #47 for the first attempt only fixing the display).

That bug was fixed in the display of the fix, but because import fixing
was using a copy-and-pasted version of the path normalization code,
it never got the fix.

I tested this locally and now it actually works.

Fixes soates#37 (see PR soates#47 for the first attempt only fixing the display).
Copy link

@abarrows abarrows left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants