Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blocker: yum-utils package has been 'deprecated' on fedora-latest #186

Closed
joshrabinowitz opened this issue Jun 8, 2018 · 8 comments
Closed

Comments

@joshrabinowitz
Copy link
Collaborator

joshrabinowitz commented Jun 8, 2018

What are the steps to reproduce this issue?

  1. create PR
  2. look at travis CI build for 'gnupg-git-fedora-latest'
    For example, the second to last build here:
    https://travis-ci.org/sobolevn/git-secret/builds/389721094
    (note also is likely the last issue to keep this build from passing)

What happens?

Travis Ci build fails and reports:

Yum-utils package has been deprecated, use dnf instead.
See 'man yum2dnf' for more information.

What were you expecting to happen?

successful build

Any logs, error output, etc?

The issue is related to
https://github.com/sobolevn/git-secret/blob/master/.ci/integration/gnupg-git/default.yml#L50
where it reads:

    - name: Install gnupg build dependencies for RedHat based distros
      command: bash -lc "yum --assumeyes install yum-utils && yum-builddep --assumeyes gnupg2"
      when:
        - ansible_os_family == "RedHat"

You can see the error output it generates here:
https://travis-ci.org/sobolevn/git-secret/jobs/389668874

Any other comments?

yum-utils has been deprecated we get a non-zero exit code.

the yum-utils package is used for the yum-builddep tool

@joshrabinowitz
Copy link
Collaborator Author

@joshrabinowitz
Copy link
Collaborator Author

joshrabinowitz commented Jun 8, 2018

Looks like we need to differentiate between redhat and fedora systems and use dnf builddep <package>... instead of yum-builddep --assumeyes gnupg2 here:

https://github.com/sobolevn/git-secret/blob/master/.ci/integration/gnupg-git/default.yml#L50

Edit: on fedora ansible_os_family == "RedHat" and ansible_distribution == "Fedora"

@simbo1905, is this something you could fix?

@simbo1905
Copy link
Collaborator

@joshrabinowitz busy testing a fix to #179 and another it uncovers. Changing other things with a broken release may continue the instability so I would like to see a 0.2.4 release before we change anything that's not a blocker.

@joshrabinowitz
Copy link
Collaborator Author

joshrabinowitz commented Jun 8, 2018

I think this issueThis issue recently became a blocker:
See the output for the second to last build, for 'gnupg-git-fedora-latest' here:

https://travis-ci.org/sobolevn/git-secret/builds/389668862

and here:
https://travis-ci.org/sobolevn/git-secret/builds/389721094

@joshrabinowitz joshrabinowitz changed the title yum-utils package has been deprecated blocker: yum-utils package has been 'deprecated' on fedora-latest Jun 8, 2018
@simbo1905 simbo1905 added the blocker blocking release label Jun 8, 2018
@simbo1905
Copy link
Collaborator

simbo1905 commented Jun 8, 2018

This is the only broken thing on the travis for my fork https://travis-ci.org/simbo1905/git-secret/builds/389789759 🚨

@simbo1905
Copy link
Collaborator

This fixes it running just that one locally the full suite is running now.

- name: Install gnupg build dependencies for RedHat based distros
  command: bash -lc "dnf -y install 'dnf-command(builddep)' && dnf builddep -y gnupg2"
  when:
    - ansible_os_family == "RedHat"

@simbo1905
Copy link
Collaborator

It now gets past this issue and fails much later with sudo: /usr/local/bin/rspec: command not found at https://travis-ci.org/sobolevn/git-secret/jobs/389884422#L3236

@joshrabinowitz
Copy link
Collaborator Author

@simbo1905 I think we can close this. Agreed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants