fix deploy issue #184
fix deploy issue #184
Conversation
| @@ -95,6 +95,7 @@ before_deploy: | |||
|
|
|||
| deploy: | |||
| - provider: bintray | |||
| skip_cleanup: true | |||
There was a problem hiding this comment.
In the log here https://api.travis-ci.org/v3/job/389282869/log.txt it says:
[Bintray Upload] Cleaning up git repository with
git stash --all. If you need build artifacts for deployment, setdeploy.skip_cleanup: true. See https://docs.travis-ci.com/user/deployment#Uploading-Files-and-skip_cleanup.
| @@ -7,7 +7,8 @@ if [[ "$GITSECRET_DIST" == "rpm" ]]; then | |||
| sudo apt-get install -y rpm; | |||
| fi | |||
|
|
|||
| if [[ ! -z "$GITSECRET_DIST" ]] && [[ -z "$KITCHEN_REGEXP" ]]; then | |||
| # if not null GITSECRET_DIST | |||
| if [[ ! -z "$GITSECRET_DIST" ]]; then | |||
There was a problem hiding this comment.
This issue here is that $KITCHEN_REGEXP is defined where $GITSECRET_DIST is defined in .travis.yml Since $GITSECRET_DIST is only defined in two places, once for deb and once for rpm in .travis.yml this change seems okay.
|
I tried this out on my own travis and saw that it attempted to deploy the artefacts. |
|
Note: The lint checks broke the build so I ripped those out to test this. |
|
The PR build looks to have passed lint but failed man tests. |
|
now we just need to resolve #179 (find man pages...) so we can merge! |
|
Closing as these changes were in #188 |
What does this implement/fix? Explain your changes.
Deploy step is ignored #120
Does this close any currently open issues?
Deploy step is ignored #120
Any other comments?
See comments in this pull request.
…