Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New CI #658

Merged
merged 18 commits into from
May 4, 2021
Merged

New CI #658

merged 18 commits into from
May 4, 2021

Conversation

sobolevn
Copy link
Owner

@sobolevn sobolevn commented May 3, 2021

Closes #657
Refs #646

@sobolevn sobolevn changed the title [WIP] New CI New CI May 3, 2021
@joshrabinowitz
Copy link
Collaborator

  • is the .ronn file deletion intended?
  • I notice the new man page files don't seem to include version numbers. intentional?
  • will look at this more in the next few days

@sobolevn
Copy link
Owner Author

sobolevn commented May 3, 2021

This is now ready to be reviewed! Releasing part is missing for now, because I first want to make sure that everything else is correct.

I understand that there are lots of changes, but I guess the final simplicity is worth the refactoring.

@sobolevn
Copy link
Owner Author

sobolevn commented May 3, 2021

@joshrabinowitz

is the .ronn file deletion intended?

It is now synced from main ./man folder into docs, see: https://github.com/sobolevn/git-secret/blob/issue-657/.github/workflows/github-pages.yml#L18

I notice the new man page files don't seem to include version numbers. intentional?

Sorry, I don't understand this one 😞

will look at this more in the next few days

Thanks a lot for your help! 👍

@sobolevn
Copy link
Owner Author

sobolevn commented May 3, 2021

Wow, this was hard 😅

@joshrabinowitz
Copy link
Collaborator

re my comment: I notice the new man page files don't seem to include version numbers.
I meant that the generated man pages (such as man/man1/git-secret-whoknows.1) no longer have the version of git-secret in the header; for example the output of git diff master -- man/man1 `shows

-.TH "GIT-SECRET-ADD" "1" "April 2021" "sobolevn" "git-secret 0.3.3"
+.TH "GIT-SECRET-ADD" "1" "May 2021" "sobolevn" "git-secret "

@joshrabinowitz
Copy link
Collaborator

Looks good otherwise

@sobolevn
Copy link
Owner Author

sobolevn commented May 4, 2021

Fixed! Thanks!

Docs preview now works via make docs
Снимок экрана 2021-05-04 в 12 16 46

@sobolevn
Copy link
Owner Author

sobolevn commented May 4, 2021

Ok, I am going to merge this one and start working on new releases. I already have a big progress on deb releases, but it requires a lot more polishing.

Any comments are still welcome, I will implement them in async mode! 👍

@sobolevn sobolevn merged commit aa70062 into master May 4, 2021
@sobolevn sobolevn deleted the issue-657 branch May 4, 2021 10:01
@sobolevn sobolevn mentioned this pull request May 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New CI
2 participants