Bdh cleanup #766
Merged
Bdh cleanup #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Feb 4, 2022
| @@ -41,7 +34,9 @@ function _show_version { | |||
|
|
|||
| function _init_script { | |||
| if [[ $# == 0 ]]; then | |||
| _incorrect_usage 'no input parameters provided.' 126 | |||
There was a problem hiding this comment.
shellcheck correctly warns that the usage() function expects parameters but is never called with any. I have just submitted a different pull request based on the current master which passes the rest of the parameter list to the usage function rather than inline it. So you can forget this part of this submission.
|
@sobolevn @bryan-howard I'm planning to merge this soon, then revert the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this implement/fix? Explain your changes.
Removes trailing whitespace.
Addresses all outstanding shellcheck warnings.
Does this close any currently open issues?
I don't think so.
Any relevant logs, error output, etc?
No.
Any other comments?
No.