Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changes to .gitignore usage and testing in response to #789 #791

Merged

Conversation

joshrabinowitz
Copy link
Collaborator

@joshrabinowitz joshrabinowitz commented Mar 15, 2022

Closes #789
Closes #792

  • cleanups, comment improvements, simplifications,
  • tests .gitignore has correct line count after add of two files

@joshrabinowitz joshrabinowitz changed the title fix writing .gitignore when using multiple files with add debug what's happening with #789 in 0.4.0 Mar 16, 2022
@joshrabinowitz joshrabinowitz changed the title debug what's happening with #789 in 0.4.0 changes to .gitignore usage in response to #789 Mar 21, 2022
@joshrabinowitz
Copy link
Collaborator Author

@sobolevn ok this is ready for re-review and merge

@joshrabinowitz joshrabinowitz changed the title changes to .gitignore usage in response to #789 changes to .gitignore usage and testing in response to #789 Mar 23, 2022
@joshrabinowitz joshrabinowitz merged commit eefa106 into sobolevn:master Mar 23, 2022
@joshrabinowitz joshrabinowitz deleted the add-multiple-files-gitignore branch March 23, 2022 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants