Skip to content

Commit

Permalink
Fixes namedtuple type name
Browse files Browse the repository at this point in the history
The best practice is to match `typename` with variable name.
For example, `mypy` reports any other usages as errors: python/mypy#11206 (comment)
  • Loading branch information
sobolevn committed Sep 27, 2021
1 parent 8c80aa3 commit f0eeade
Showing 1 changed file with 3 additions and 3 deletions.
6 changes: 3 additions & 3 deletions tests/integration_tests/test_chainer.py
Original file line number Diff line number Diff line change
Expand Up @@ -80,8 +80,8 @@ def test_chainer_pruning_extension_observation_nan() -> None:
trial = create_running_trial(study, 1.0)
extension = ChainerPruningExtension(trial, "main/loss", (1, "epoch"))

MockTrainer = namedtuple("_MockTrainer", ("observation", "updater"))
MockUpdater = namedtuple("_MockUpdater", ("epoch"))
MockTrainer = namedtuple("MockTrainer", ("observation", "updater"))
MockUpdater = namedtuple("MockUpdater", ("epoch"))
trainer = MockTrainer(observation={"main/loss": float("nan")}, updater=MockUpdater(1))

with patch.object(extension, "_observation_exists", Mock(return_value=True)) as mock:
Expand All @@ -94,7 +94,7 @@ def test_observation_exists() -> None:

study = optuna.create_study()
trial = create_running_trial(study, 1.0)
MockTrainer = namedtuple("_MockTrainer", ("observation",))
MockTrainer = namedtuple("MockTrainer", ("observation",))
trainer = MockTrainer(observation={"OK": 0})

# Trigger is deactivated. Return False whether trainer has observation or not.
Expand Down

0 comments on commit f0eeade

Please sign in to comment.