Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use 1 SD instead of 2 SD when edge cleansing timeline items #31

Closed
sobri909 opened this issue Jul 21, 2018 · 3 comments
Closed

Use 1 SD instead of 2 SD when edge cleansing timeline items #31

sobri909 opened this issue Jul 21, 2018 · 3 comments
Assignees

Comments

@sobri909
Copy link
Owner

Pre-LocoKit Arc App used 1 SD for all visit radius tasks, both display and processing. LocoKit has instead always used 2 SD.

2 SD is more "correct", but it means that visits look fatter on the map, and makes the edge cleansing versus paths much more hungry.

The fatter presentation on the map is probably fine. It does show a more true radius for the visit. But the greedy edge cleansing can be too much, especially when dealing with visits to places that are only a short distance apart.

So yeah, I want to try going back to 1 SD for edge cleansing.

@sobri909 sobri909 self-assigned this Jul 21, 2018
sobri909 added a commit that referenced this issue Jul 23, 2018
@sobri909
Copy link
Owner Author

Yeah, path-visit edges are looking much better after the SD change.

Yesterday (2 SD) Today (1 SD)
Before After

I'll leave this task open another day or two, just in case any weird quirks turn up. But looks like a success so far.

@sobri909
Copy link
Owner Author

Note that this change is live in Arc App v2.1.3, which will be going live presumably later today. (It's been in the review queue for 12+ hours, so it shouldn't be too far off).

@sobri909
Copy link
Owner Author

Closing this, as it at the very least hasn't caused any troubles. I'd still like to do more tweaking to visit radiuses, but I think this SD change on edge cleansing is still a step in the right direction, so it's good to stay.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant