Events Feature from PR #679 #892
Conversation
.gitignore
Outdated
| @@ -221,3 +221,5 @@ FakesAssemblies/ | |||
| **/*.Server/GeneratedArtifacts | |||
| **/*.Server/ModelManifest.xml | |||
| _Pvt_Extensions | |||
|
|
|||
| somefuck | |||
There was a problem hiding this comment.
github not build if i doing force push :) i will squash all after changes
README.md
Outdated
| request.Peer = peer; | ||
| client.SendRequestAsync<bool>(request).Wait(); | ||
| } | ||
| catch {} |
There was a problem hiding this comment.
rather than a catch-all, can you please specify the type of exception here please
| //logger.debug("processMessage: msg_id {0}, sequence {1}, data {2}", BitConverter.ToString(((MemoryStream)messageReader.BaseStream).GetBuffer(), (int) messageReader.BaseStream.Position, (int) (messageReader.BaseStream.Length - messageReader.BaseStream.Position)).Replace("-","").ToLower()); | ||
| needConfirmation.Add(messageId); | ||
| Ack().Wait(); |
There was a problem hiding this comment.
shouldn't this use await Ack();?
There was a problem hiding this comment.
Error: The 'await' operator can only be used within an async method.
I will return it back, sorry limited by time
There was a problem hiding this comment.
then make processMessage be async
There was a problem hiding this comment.
Then here is 5 methods in a row, to be async
There was a problem hiding this comment.
the method Ack does not need to be async as the method it calls Send does not have any await calls itself. Should these still be marked async ?
| @@ -42,6 +42,10 @@ | |||
| <Reference Include="System.Data" /> | |||
| <Reference Include="System.Net.Http" /> | |||
| <Reference Include="System.Xml" /> | |||
| <Reference Include="NLog"> | |||
There was a problem hiding this comment.
I'm guessing the no-polling feature can exist without adding NLog, let's mix this change in this PR
| } | ||
| } | ||
|
|
||
| private void _sender_UpdatesEvent (TLAbsUpdates updates) |
There was a problem hiding this comment.
please use PascalCase for method names
| { | ||
| var peer = new TLInputPeerUser() { UserId = status.UserId }; | ||
| client.SendMessageAsync(peer, "Você está online.").Wait(); | ||
| } catch {} |
|
Superseded by #940 |
Here is one commit changes from #679 PR. All changes is merged and cleaned. All dep's updates reverted.
If that project need such upgrade merge & change it for project needs.