-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump all Remix packages to the latest version #31
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
JacobBaqleh1
previously approved these changes
Jul 19, 2023
andrelandgraf
approved these changes
Jul 20, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for doing this! Great PR description! 💯
/api/metafile.js.json | ||
/api/metafile.server.json | ||
|
||
.DS_Store |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
My fav file!
shami-dev
approved these changes
Jul 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: N/A
Summary (1-2 sentences)
Update all Remix packages to the latest version and add new metafiles generated to
.gitignore
.Changed in
package.json
:Added to
.gitignore
:Details (reason and description of the changes)
Our current Remix version (< 1.16.1) is not compatible with Node version >= 20. Attempting to run the project with Node >= 20 will return
TypeError: Value of "this" must be of type URLSearchParams
. This issue is also documented in the Remix repo in issue #6118.The
.gitignore
has also been updated to includeesbuild
metafiles since the latest Remix version now generates these files by default for bundle analysis per Remix PR #6772.Alternative implementations (what alternatives were considered and why were they disregarded?) (optional)
An alternative solution is to include @remix-run/web-fetch@^4.3.4 as a dependency to avoid errors when using Node >= 20. However, the latest Remix version already addresses the error, so it is no longer necessary to need to include an additional dependency for the project.