Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump all Remix packages to the latest version #31

Merged
merged 4 commits into from
Jul 20, 2023

Conversation

tonydangblog
Copy link
Contributor

@tonydangblog tonydangblog commented Jul 19, 2023

Issue: N/A

Summary (1-2 sentences)

Update all Remix packages to the latest version and add new metafiles generated to .gitignore.

Changed in package.json:

@remix-run/node: ^1.7.2 -> ^1.19.0
@remix-run/react: ^1.7.2 -> ^1.19.0
@remix-run/vercel: ^1.7.2 -> ^1.19.0
@remix-run/dev: ^1.7.2 -> ^1.19.0
@remix-run/eslint-config: ^1.7.2 -> ^1.19.0
@remix-run/serve: ^1.7.2 -> ^1.19.0

Added to .gitignore:

/api/metafile.css.json
/api/metafile.js.json
/api/metafile.server.json
.DS_Store

Details (reason and description of the changes)

Our current Remix version (< 1.16.1) is not compatible with Node version >= 20. Attempting to run the project with Node >= 20 will return TypeError: Value of "this" must be of type URLSearchParams. This issue is also documented in the Remix repo in issue #6118.

The .gitignore has also been updated to include esbuild metafiles since the latest Remix version now generates these files by default for bundle analysis per Remix PR #6772.

Alternative implementations (what alternatives were considered and why were they disregarded?) (optional)

An alternative solution is to include @remix-run/web-fetch@^4.3.4 as a dependency to avoid errors when using Node >= 20. However, the latest Remix version already addresses the error, so it is no longer necessary to need to include an additional dependency for the project.

@tonydangblog tonydangblog added bug Something isn't working dev environment Changes that involve updates to our dev enviroment labels Jul 19, 2023
@tonydangblog tonydangblog self-assigned this Jul 19, 2023
@vercel
Copy link

vercel bot commented Jul 19, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
plan-it-social-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 20, 2023 0:21am

JacobBaqleh1
JacobBaqleh1 previously approved these changes Jul 19, 2023
Copy link
Contributor

@andrelandgraf andrelandgraf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Great PR description! 💯

/api/metafile.js.json
/api/metafile.server.json

.DS_Store
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My fav file!

@tonydangblog tonydangblog merged commit 241bdee into main Jul 20, 2023
2 checks passed
@tonydangblog tonydangblog deleted the tonydangblog/update-remix branch July 20, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working dev environment Changes that involve updates to our dev enviroment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

None yet

4 participants