Skip to content
This repository has been archived by the owner on Oct 5, 2023. It is now read-only.

Mega-fix bundle #17

Merged
merged 5 commits into from Oct 13, 2011
Merged

Mega-fix bundle #17

merged 5 commits into from Oct 13, 2011

Conversation

philsturgeon
Copy link
Contributor

Now, I know normally single changes and single bug-fixes are required to be sent in one at a time but there seems to be a few valid fixes floating around for various problems that the original authors are not sending in to you.

This gem has not been updated in a month and looking at your network some errors are being fixed multiple times.

I've had various problems and by combining all of these into a single location I have got my gem working nicely on Rack 1.3.3, Rails 3.1 and Ruby 1.9.2 with the very latest OAuth 2 gem from intridea.

Please can you merge this whole bunlde of commits, as it fixes a series of issues. Right now your gem does not follow the final spec so it breaks :)

@renatovico
Copy link

+1

@wireframe
Copy link
Contributor

thanks for putting this together.

honestly, the only thing i'm hesitant with this change is exposing an external UI for managing clients. IMO, this is extremely application specific and well outside the definition of the oauth2 spec (intentionally). each application has it's own requirements around oauth2 client creation (ex: clients may be directly associated to the owning user), and I find it difficult to generalize it for use as a drop in gem.

not to mention the security implications which are not addressed here (ex: any user can edit any client).

@philsturgeon
Copy link
Contributor Author

Yeah that one slipped in hang about.

@philsturgeon
Copy link
Contributor Author

I've removed the client gui and an errorneous commit of my own from this pull request. Please merge.

@wireframe wireframe merged commit b566ae2 into socialcast:master Oct 13, 2011
@wireframe
Copy link
Contributor

thanks. merged changes and released v0.3.8 gem.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants