[MRG] Sort TableList by order of tables in PDF #283
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
symroe
force-pushed
the
277_table_sorting
branch
from
ecd1e36
to
8446271
Compare
Codecov Report
@@ Coverage Diff @@
## master #283 +/- ##
==========================================
+ Coverage 87.39% 87.44% +0.05%
==========================================
Files 13 13
Lines 1491 1497 +6
Branches 343 346 +3
==========================================
+ Hits 1303 1309 +6
Misses 131 131
Partials 57 57
Continue to review full report at Codecov.
|
vinayak-mehta
changed the title
|
Thanks for the PR! @symroe |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #277
c019e58 is fairly easy, and is useful for some cases where the
Tableobjects have got mixed up for some reason, or where reversing them is useful.8446271 I'm less sure about. When I opened the issue I thought I'd found a PDF that causes camelot to return tables in an order not defined in the PDF. I can't reproduce this, so I can't make a regression test for it. Very happy if you'd like me to pick that commit out, although I don't think it's doing any harm as it stands.