Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Also include schedules for "Standalone Containers" #10

Closed
dirkdevriendt opened this issue Sep 15, 2016 · 3 comments
Closed

Also include schedules for "Standalone Containers" #10

dirkdevriendt opened this issue Sep 15, 2016 · 3 comments

Comments

@dirkdevriendt
Copy link

Great project!
For one of our services, I added a container manually with the appropriate schedule config label, but was surprised to see it did not get picked up.
I'm assuming this is because rancher-cron queries for services and containers in those services, causing the Standalone Containers to not get listed, but I haven't dug in too much so I may be mistaken...

@smazurov
Copy link
Contributor

smazurov commented Sep 15, 2016

That is correct. I believe thats a limitation of rancher api - we query each service to see if they have the right label, then we find container with that label. You can see this in action here. From when I looked at rancher metadata api last, there was not an equivalent container-level lookup.

Meaning, we cannot query rancher api directly for containers with that label, thus standalone containers will not be picked up. Only way I see to make it happen is to loop through all containers, which is too costly.

Any reason why you cannot create a stack with a single start-once service?

@dirkdevriendt
Copy link
Author

No reason at all, I was just wondering if I was understanding it correctly (and if other people encounter the same thing, they may find this message).
It could be added as an optional setting at some point, but I understand the performance cost could be prohibitive for large clusters and as you say, it is easy to work around.
Thanks for taking the time to reply!

@smazurov
Copy link
Contributor

No problem. Easy fix would be to lookup containers by label instead of service, but that would be on rancher api side. Closing for now, but thanks for your interest!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants