Skip to content

Commit

Permalink
refactor the audiences index action
Browse files Browse the repository at this point in the history
  • Loading branch information
acmetech committed Mar 24, 2014
1 parent 6983fb9 commit e8c17db
Showing 1 changed file with 19 additions and 12 deletions.
31 changes: 19 additions & 12 deletions app/controllers/socializer/audiences_controller.rb
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,25 @@ class AudiencesController < ApplicationController
before_action :authenticate_user!

def index
query = params.fetch(:q) { nil }
query = params.fetch(:q) { nil }
results = user_audience_list(current_user, query)

audiences = []

audiences << Audience.privacy_level_hash(:public)
audiences << Audience.privacy_level_hash(:circles)
audiences.concat(results.people)
audiences.concat(results.circles)
audiences.concat(results.groups)

respond_to do |format|
format.json { render json: audiences }
end
end

private

def user_audience_list(current_user, query)
people = []
circles = current_user.circles.select(:name).guids
groups = current_user.groups.select(:name).guids
Expand All @@ -24,17 +41,7 @@ def index
# groups = groups.where { name.like(query_value) }
end

audiences = []

audiences << Audience.privacy_level_hash(:public)
audiences << Audience.privacy_level_hash(:circles)
audiences.concat(people)
audiences.concat(circles)
audiences.concat(groups)

respond_to do |format|
format.json { render json: audiences }
end
OpenStruct.new(people: people, circles: circles, groups: groups)
end
end
end

0 comments on commit e8c17db

Please sign in to comment.