Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix in operator bug. #36

Merged
merged 1 commit into from
Nov 15, 2018
Merged

Fix in operator bug. #36

merged 1 commit into from
Nov 15, 2018

Conversation

maruqu
Copy link
Contributor

@maruqu maruqu commented Nov 14, 2018

File "/usr/local/lib/python3.7/site-packages/flask_jsonapi/utils/sqlalchemy_django_query.py", line 131, in _filter_or_exclude q = q.filter(negate_if(op(column, *to_list(value)))) TypeError: in_op() takes 2 positional arguments but 3 were given


This change is Reviewable

`File "/usr/local/lib/python3.7/site-packages/flask_jsonapi/utils/sqlalchemy_django_query.py", line 131, in _filter_or_exclude
    q = q.filter(negate_if(op(column, *to_list(value))))
TypeError: in_op() takes 2 positional arguments but 3 were given`
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.484% when pulling c26b770 on fix-in-operator into 3f40aa6 on master.

1 similar comment
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 94.484% when pulling c26b770 on fix-in-operator into 3f40aa6 on master.

@jgoclawski
Copy link
Member

LGTM 👍

@jgoclawski jgoclawski merged commit 6906589 into master Nov 15, 2018
@Behoston Behoston deleted the fix-in-operator branch February 20, 2019 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants