Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace copyright notices to dunnhumby Germany GmbH #318

Conversation

andreas-bok-sociomantic
Copy link
Contributor

Due to organizational changes in sociomantic labs GmbH the copyright owner must be updated to the legal entity "dunnhumby Germany GmbH".

@andreas-bok-sociomantic andreas-bok-sociomantic added this to the v6.1.5 milestone Nov 2, 2018
Copy link
Collaborator

@ben-palmer-sociomantic ben-palmer-sociomantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment not strictly related to the PR. Fix if you like.

README.rst Outdated
@@ -173,6 +169,4 @@ the `Tsunami programme`_ created by `sociomantic labs GmbH`_.
.. _All: https://github.com/sociomantic-tsunami/libdrizzle-redux/releases/
.. _here: https://github.com/sociomantic-tsunami/neptune/blob/master/doc/library-user.rst
.. _compiling.rst: https://github.com/andreas-bok-sociomantic/libdrizzle-redux/blob/v5.4.x/docs/compiling.rst
.. _Tsunami programme: https://github.com/sociomantic-tsunami
.. _sociomantic labs GmbH: https://www.sociomantic.com
.. _Neptune: https://github.com/sociomantic-tsunami/neptune/blob/master/doc/library-user.rst#contributing-to-a-neptune-versioned-library
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not strictly related to this PR but the neptune links are broken. Should be:
https://github.com/sociomantic-tsunami/neptune/blob/v0.x.x/doc/library-user.rst
and
https://github.com/sociomantic-tsunami/neptune/blob/v0.x.x/doc/library-user.rst#contributing-to-a-neptune-versioned-library

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱 I will make a separate PR to fix them

@ben-palmer-sociomantic
Copy link
Collaborator

Need to rebase on master now :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Due to organizational changes in sociomantic labs GmbH
the copyright owner must be updated to the legal
entity "dunnhumby Germany GmbH".
@andreas-bok-sociomantic
Copy link
Contributor Author

Fixed conflict

@ben-palmer-sociomantic
Copy link
Collaborator

LGTM

@ben-palmer-sociomantic ben-palmer-sociomantic merged commit 6eb5944 into sociomantic-tsunami:v6.1.x Nov 2, 2018
@andreas-bok-sociomantic andreas-bok-sociomantic deleted the update-copyright-notice-v6.1.5 branch November 2, 2018 15:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants