Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new turtle test node based directly on NodeBase #353

Open
wants to merge 6 commits into
base: v6.x.x
Choose a base branch
from

Commits on Aug 23, 2018

  1. Remove unused import

    Gavin Norman committed Aug 23, 2018
    Configuration menu
    Copy the full SHA
    08afa14 View commit details
    Browse the repository at this point in the history

Commits on Aug 24, 2018

  1. Move construction of INodeBase's select listeners into abstract methods

    References to the listeners are required by INodeBase, but these were
    previously passed into the ctor from outside, rather than being owned and
    controlled by this class. This, combined with the lack of support in ocean
    for reopening a shutdown listener, made it impossible to implement a method
    to restart the node's listeners.
    
    (The ideal solution, of course, would be to add the missing restart support
    to the select listener in ocean, but this will require a major swarm
    release.)
    Gavin Norman committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    ff0a117 View commit details
    Browse the repository at this point in the history
  2. Add NodeBase.restartListeners

    (As a counterpart to the existing stopListener.)
    Gavin Norman committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    003e1d3 View commit details
    Browse the repository at this point in the history
  3. Rename NodeBase.stopListener -> stopListeners

    There's more than one listener now.
    Gavin Norman committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    22e2b20 View commit details
    Browse the repository at this point in the history
  4. Add turtle.env.model.TestNode

    This is intended as a replacement of the existing turtle.env.model.Node.
    The reason for the new class is that the turtle/swarm node framework is
    currently fairly complicated, with several different classes required to
    implement a fake node. The new TestNode derives directly from NodeBase (the
    standard base class for swarm nodes), whereas the older Node does not. This
    means that to implement a fake node using TestNode, one does not have to
    separately write a class deriving from NodeBase.
    Gavin Norman committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    357a743 View commit details
    Browse the repository at this point in the history
  5. Adapt the turtle env node test to use the new TestNode

    Gavin Norman committed Aug 24, 2018
    Configuration menu
    Copy the full SHA
    62c2478 View commit details
    Browse the repository at this point in the history