Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Separate LCE classes into a separate module #24

Open
dimsuz opened this issue Apr 25, 2017 · 2 comments
Open

Separate LCE classes into a separate module #24

dimsuz opened this issue Apr 25, 2017 · 2 comments

Comments

@dimsuz
Copy link

dimsuz commented Apr 25, 2017

Currently when using mvp-conductor an LCE classes automatically add dependencies to mosby's LCE and ViewState modules:

+--- com.hannesdorfmann.mosby3:mvp-conductor:3.0.0@aar
|    \--- com.hannesdorfmann.mosby3:mvp-lce:3.0.0@aar
|         \--- com.hannesdorfmann.mosby3:viewstate:3.0.0@aar

In my projects I do not use those modules, because I provide my own LCE implementations. But currently I still have these two additional dependencies which I do not even use...

It would be great to have mvp-conductor-lce or something like this, so that there can be more fine grained tuning.

Are you planning on doing something like this or do you oppose these changes?
I might try to come up with PR if this is acceptable and if you didn't already start this.

@sockeqwe
Copy link
Owner

Yes, that is something I have considered to do for 3.0 but I have dropped the idea for 3.0.
The reason was that it would require Mosby (not the conductor repository) to extract the LCE View Interface into it's own module and publish it as it's own jar so that both com.hannesdorfmann.mosby3:mvp-lce:x.y.z and com.hannesdorfmann.mosby3:conductor-lce:x.y.z can include it.

Given the fact that mosby-conductor is not very popular, I found it not worthwhile to add this separate module just for the LCE view interface.

@dimsuz
Copy link
Author

dimsuz commented Apr 25, 2017

Ah, I see. Those modules, sometimes they seem to multiply at an unusually fast rate! :)

This issue should be closed then I guess...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants