implement AsPtr for CanAnyFrame #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jreppnow
force-pushed
the
fix_trait_requirements
branch
from
1efb834
to
6261346
Compare
|
CI failure is not related to PR, see #44 (and merge that one first, will rebase this one onto the other PR) |
jreppnow
force-pushed
the
fix_trait_requirements
branch
from
6261346
to
7cdc0a6
Compare
|
Thanks for the PR! I just quickly pushed out a pair of releases and totally forgot to look at the PR's. I'll get these in an do another release ASAP. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! This fixes the somewhat comical issue that I cannot directly put a
CanAnyFrameback into aCanFdSocketfrom which I have received it. Bit ugly with thec_voidand making thesizefunction non-static, but the smallest possible increment within the current implementation..