Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

activity-streams should provide sourcemaps #237

Closed
gregkare opened this issue Apr 9, 2019 · 3 comments · Fixed by #238 or #596
Closed

activity-streams should provide sourcemaps #237

gregkare opened this issue Apr 9, 2019 · 3 comments · Fixed by #238 or #596
Labels
package:activity-streams Issues related to ActivityStreams.js type:bug
Projects
Release: Current
Milestone
Hyperchannel Alpha

Comments

@gregkare
Copy link
Contributor

gregkare commented Apr 9, 2019 •
edited by silverbucket

See 67P/hyperchannel#161

We are using https://sockethub.kosmos.org:10550/activity-streams.js, but now only https://sockethub.kosmos.org:10550/activity-streams.min.js is provided

We're changing Hyperchannel to use the minified version, having sourcemaps would help when developing
@gregkare gregkare mentioned this issue Apr 9, 2019
Closed
@galfert galfert self-assigned this Apr 10, 2019
galfert added a commit that referenced this issue Apr 11, 2019
@galfert
Re-add unminified activity-streams.js file
60c1eaa 
Fixes #237

Removing the file broke existing apps linking it.
@galfert galfert mentioned this issue Apr 11, 2019
Merged
@ghost ghost added the [zube]: In Progress label Apr 11, 2019
galfert added a commit that referenced this issue Apr 11, 2019
@galfert
Re-add unminified activity-streams.js file
f66162d 
Fixes #237

Removing the file broke existing apps linking to it.
@ghost ghost removed the [zube]: Done label May 14, 2019
@gregkare
Copy link
Contributor Author

#238 did not fix the issue, as the activity-streams npm module doesn't contain the unminified file since 3.1.0. Sockethub depends on 4.1.0 right now

@gregkare gregkare reopened this May 15, 2019
@gregkare gregkare changed the title activity-streams is only provided minified in sockethub 3.0 activity-streams should provide sourcemaps May 15, 2019
@galfert galfert mentioned this issue May 15, 2019
Merged
@silverbucket silverbucket added this to the Core milestone Oct 22, 2020
@silverbucket silverbucket modified the milestones: Core, Medium Priority, High Priority Aug 28, 2021
@silverbucket silverbucket added the package:activity-streams Issues related to ActivityStreams.js label Aug 28, 2021
@silverbucket
Copy link
Member

@galfert @gregkare - this should no longer be an issue, as activity-streams.js is packaged/bundled together into the sockethub-client.js

@silverbucket silverbucket reopened this Aug 29, 2021
@silverbucket
Copy link
Member

Turns out we do still need sourcemaps for activity-streams.js

@silverbucket silverbucket removed this from the 1. High Priority milestone Aug 29, 2021
@silverbucket silverbucket added this to the 2. Medium Priority milestone Aug 29, 2021
@silverbucket silverbucket added this to To do in Release: Current via automation Aug 29, 2021
@silverbucket silverbucket modified the milestones: 2. Medium Priority, 3. Low Priority Aug 29, 2021
@silverbucket silverbucket modified the milestones: 3. Low Priority, Hyperchannel Closed Demo Sep 2, 2021
@silverbucket silverbucket removed this from To do in Release: Current Sep 4, 2021
@silverbucket silverbucket added this to To do in Release: Next via automation Sep 4, 2021
@silverbucket silverbucket removed this from To do in Release: Next Sep 4, 2021
@silverbucket silverbucket added this to To do in Release: Current via automation Sep 4, 2021
@silverbucket silverbucket linked a pull request Sep 25, 2021 that will close this issue
Refactor sockethub-client #596
Merged
Release: Current automation moved this from To do to Done Jan 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
package:activity-streams Issues related to ActivityStreams.js type:bug
Projects
Release: Current
Done
Milestone
Hyperchannel Alpha
3 participants
@galfert @gregkare @silverbucket