Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove passing of credentials on each platform method #287

Closed
silverbucket opened this issue Nov 17, 2020 · 2 comments · Fixed by #344
Closed

Remove passing of credentials on each platform method #287

silverbucket opened this issue Nov 17, 2020 · 2 comments · Fixed by #344
Assignees
@silverbucket

Comments

@silverbucket
Copy link
Member

Only pass in credentials on connect
@silverbucket silverbucket added this to the Core milestone Nov 19, 2020
@silverbucket silverbucket self-assigned this Nov 19, 2020
@silverbucket silverbucket mentioned this issue Mar 10, 2021
Merged
@galfert
Copy link
Contributor

galfert commented Mar 12, 2021

Shouldn't this issue still be kept open? So far #344 was only in preparation of removing it from the other methods.

@silverbucket
Copy link
Member Author

@galfert I don't think so, since now whether credentials are passed in or not is left as a config option to the platform, the platforms can be reworked over time with their own issues (eg. just refactoring those platforms in general).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@silverbucket silverbucket

Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@galfert @silverbucket