New config option to define which platform methods require the credentials option passed in. #344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… the credentials object passed in
galfert
approved these changes
Mar 11, 2021
Co-authored-by: Garret Alfert <alfert@wevelop.de>
silverbucket
added a commit
that referenced
this pull request
Mar 16, 2021
…tials option passed in. (#344) * use requireCredentials property to define which platform methods need the credentials object passed in Co-authored-by: Garret Alfert <alfert@wevelop.de> Co-authored-by: Garret Alfert <alfert@wevelop.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently credentials are passed in to every platform function which were previously used to access the appropriate client instance or re-connect if needed. The architecture has progressively moved away from that to simply destroying and restarting the platform if the connection is lost. This PR adds a
requireCredentialsproperty to the platform config, which is an array listing every method that needs the credentials object passed in. For now, all functions are defined, but as the client internals of each platform is improved we can slowly remove methods from the list.Resolves #287