Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Connecting to IRC doesn't work anymore #311

Closed
galfert opened this issue Jan 7, 2021 · 0 comments
Closed

Connecting to IRC doesn't work anymore #311

galfert opened this issue Jan 7, 2021 · 0 comments
Assignees
Labels

Comments

@galfert
Copy link
Contributor

galfert commented Jan 7, 2021

When testing PR #303, I noticed that I couldn't connect to IRC with Hyperchannel anymore when using a dev Sockethub instance.

The only messages in the Sockethub logs that I noticed as potentially relevant were these:

sockethub:core received (failed) job for non-existent socket qEzKQHdEJ_zUFF2HAAAA +33s
sockethub:core job #3 on socket osB-sQ7Vl70kStyiAAAB failed +26s
sockethub:core job #4 on socket osB-sQ7Vl70kStyiAAAB failed +2ms

I didn't see any errors in the JS console in Hyperchannel.

I think the problem was introduced with commit 98d07ff.

@silverbucket has noted some ideas about the particular changes which could be the reason in #303 (comment):

This looks like something that I had "fixed" (commented out in the past) that I remembered I'd done for Hyperchannel, but when I was paired with @raucao neither of us could think of any good reason for this -

So we re-enabled the secure logic... I am still confused as to why we needed to make that change in the first place.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants