Documentation link fixes #533
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a couple documentation relative links
|
I wonder if these paths are intentional so that it works on https://www.npmjs.com/package/sockethub. I also wonder how other monorepos deal with this problem. |
|
Hmm, I've had this issue before with non monorepos and just had to use an
absolute URL
…On Sat, Aug 21, 2021, 3:25 AM Râu Cao ***@***.***> wrote:
I wonder if these paths are intentional so that it works on
https://www.npmjs.com/package/sockethub. I wonder how other monorepos
deal with this.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#533 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABTSGCEPELOWURG75UXUMPLT55IH7ANCNFSM5CRNW3ZQ>
.
|
silverbucket
approved these changes
Aug 25, 2021
|
Ah yes, this was originally copied from the README at the root of the repo, hence the bad paths. Thanks @Cobertos! |
silverbucket
pushed a commit
that referenced
this pull request
Aug 25, 2021
Fixes a couple documentation relative links
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a couple documentation relative links