Skip to content

Commit

Permalink
fix(react-native): add a default value for the withCredentials option
Browse files Browse the repository at this point in the history
The undefined value breaks React Native on Android with a rather cryptic error message:

```
Attempt to invoke virtual method 'boolean java.lang.Boolean.booleanValue() on a null object reference
```

This bug was introduced by [1].

[1]: 5f47a50

Related: socketio/socket.io-client#1403
  • Loading branch information
darrachequesne committed Nov 16, 2020
1 parent 82987d5 commit ccb99e3
Showing 1 changed file with 1 addition and 0 deletions.
1 change: 1 addition & 0 deletions lib/socket.js
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,7 @@ class Socket extends Emitter {
{
path: "/engine.io",
agent: false,
withCredentials: false,
upgrade: true,
jsonp: true,
timestampParam: "t",
Expand Down

0 comments on commit ccb99e3

Please sign in to comment.