-
Notifications
You must be signed in to change notification settings - Fork 357
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Integrating gulp, webpack, babel #455
Conversation
Merge branch 'gulp' into babel
Conflicts: gulpfile.js
@@ -4,3 +4,4 @@ build | |||
components | |||
/coverage | |||
npm-debug.log | |||
/.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be put on global .gitignore
Don't use dynamic dependencies
One outstanding issue: The worker test now outputs a |
exclude: /(node_modules|bower_components)/, | ||
loader: 'babel', // 'babel-loader' is also a legal name to reference | ||
query: { | ||
presets: ['react', 'es2015'] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if we use react
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
okay i think i will remove that
👍 basically, looks awesome to me. |
} | ||
|
||
function cleanFiles(globArray) { | ||
console.log('cleaned generated files: ' + del.sync(globArray)); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think no message is better for cleanup.
gulp.task("default", ["build"]); | ||
|
||
gulp.task("build", function() { | ||
return gulp.src(["lib/*.js", "lib/transports/*.js"], { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lib/**/*.js
would be great here
Integrating gulp, webpack, babel
No description provided.